[ https://issues.apache.org/jira/browse/SOLR-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885115#comment-17885115 ]
Christos Malliaridis commented on SOLR-1990: -------------------------------------------- More checks have been added where blockUntilFinished() is called (see below). Can this ticket be resolved? >From current ConcurrentUpdateSolrClient (StreamingUpdateSolrServer was >renamed): {code:java} // this happens for commit... if (streamDeletes) { if ((req.getDocuments() == null || req.getDocuments().isEmpty()) && (req.getDeleteById() == null || req.getDeleteById().isEmpty()) && (req.getDeleteByIdMap() == null || req.getDeleteByIdMap().isEmpty())) { if (req.getDeleteQuery() == null) { blockUntilFinished(); return client.request(request, collection); } } } else { if ((req.getDocuments() == null || req.getDocuments().isEmpty())) { blockUntilFinished(); return client.request(request, collection); } } {code} > blockUntilFinished() is called in StreamingUpdateSolrServer more often then > it should > ------------------------------------------------------------------------------------- > > Key: SOLR-1990 > URL: https://issues.apache.org/jira/browse/SOLR-1990 > Project: Solr > Issue Type: Bug > Components: clients - java > Affects Versions: 1.4.1 > Reporter: ofer fort > Priority: Major > Original Estimate: 24h > Remaining Estimate: 24h > > in the StreamingUpdateSolrServer .request() it identifies a commit/optimize > request by having no document... > {code} > // this happens for commit... > if( req.getDocuments()==null || req.getDocuments().isEmpty() ) { > blockUntilFinished(); > {code} > ...but there are other situations where an UpdateRequest will nave no > documents (delete, updates using stream.url or stream.file, etc...) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org