[ https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885204#comment-17885204 ]
ASF subversion and git services commented on SOLR-17448: -------------------------------------------------------- Commit 758d1d7156f8d90faa3671c0527746e2ae7eb5de in solr's branch refs/heads/main from Andrey Bozhko [ https://gitbox.apache.org/repos/asf?p=solr.git;h=758d1d7156f ] SOLR-17448: Audit usage of ExecutorService#submit (#2707) Fixed inadvertent suppression of exceptions in the background tasks across the codebase. For certain tasks that were scheduled via ExecutorService#submit, the results of the task execution were never examined which led to the suppression of exceptions. > Audit usage of ExecutorService#submit in Solr codebase > ------------------------------------------------------ > > Key: SOLR-17448 > URL: https://issues.apache.org/jira/browse/SOLR-17448 > Project: Solr > Issue Type: Improvement > Affects Versions: 9.7 > Reporter: Andrey Bozhko > Priority: Minor > Labels: pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > There are quite a few places in Solr codebase where the background task is > created by invoking `ExecutorService#submit(...)` method - but where the > reference to the returned future is not retained. > So if the background task fails for any reason, and the task doesn't itself > have a try-catch block to log the failure, - the failure will go completely > unnoticed. > > This ticket is to review the usage of ExecutorService#submit method in the > codebase, and replace those with Executor#execute where appropriate. > > Originally brought up in the dev mailing list: > [https://lists.apache.org/thread/5f1965rltcspgw0j8nzcn2qnz9l4s8qm] -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org