[ 
https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley resolved SOLR-17448.
---------------------------------
    Fix Version/s: 9.8
       Resolution: Fixed

Also back ported to 9.8 – 
[24bd803|https://github.com/apache/solr/commit/24bd8039173a7270826301f982342ab1455429e8]

Thanks for contributing Andrey!

> Audit usage of ExecutorService#submit in Solr codebase
> ------------------------------------------------------
>
>                 Key: SOLR-17448
>                 URL: https://issues.apache.org/jira/browse/SOLR-17448
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 9.7
>            Reporter: Andrey Bozhko
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 9.8
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> There are quite a few places in Solr codebase where the background task is 
> created by invoking `ExecutorService#submit(...)` method - but where the 
> reference to the returned future is not retained.
> So if the background task fails for any reason, and the task doesn't itself 
> have a try-catch block to log the failure, - the failure will go completely 
> unnoticed.
>  
> This ticket is to review the usage of ExecutorService#submit method in the 
> codebase, and replace those with Executor#execute where appropriate.
>  
> Originally brought up in the dev mailing list: 
> [https://lists.apache.org/thread/5f1965rltcspgw0j8nzcn2qnz9l4s8qm]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to