dsmiley commented on PR #2701: URL: https://github.com/apache/solr/pull/2701#issuecomment-2379925519
Barring benchmarks & CHANGES.txt, I think this is ready to merge. I changed to using a blocking strategy instead of caller-runs. It should be easier to manage a Solr node's CPU consumption; more queries aren't going to tip it over (within reason). But to maximize a machine's resources, it may be necessary to configure a multiple of the number of available CPUs; we'll see I guess. I could see follow-on work to ensure there's prioritization of an earlier request's submissions over that of another concurrently happening slightly after. But I suppose it doesn't *really* matter. Also, maybe the search *itself* (i.e. thread processing SearchHandler) should use this executor? Although it's not necessarily CPU-bound (does distributed-search) whereas segment-search is. But we could do the distrib=false requests here. Hmm. An experiment for another day. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
