zkendall commented on code in PR #2799:
URL: https://github.com/apache/solr/pull/2799#discussion_r1818181559
##########
solr/core/src/test-files/solr/configsets/cloud-minimal/conf/schema.xml:
##########
@@ -19,10 +19,12 @@
<fieldType name="string" class="solr.StrField"/>
<fieldType name="int" class="${solr.tests.IntegerFieldType}"
docValues="${solr.tests.numeric.dv}" precisionStep="0" omitNorms="true"
positionIncrementGap="0" uninvertible="true"/>
<fieldType name="long" class="${solr.tests.LongFieldType}"
docValues="${solr.tests.numeric.dv}" precisionStep="0" omitNorms="true"
positionIncrementGap="0" uninvertible="true"/>
+ <fieldType name="_nest_path_" class="solr.NestPathField"/>
<dynamicField name="*" type="string" indexed="true" stored="true"/>
<!-- for versioning -->
<field name="_version_" type="long" indexed="true" stored="true"/>
<field name="_root_" type="string" indexed="true" stored="true"
multiValued="false" required="false"/>
+ <field name="_nest_path_" type="_nest_path_"/>`
Review Comment:
I was a bit worried about that. Technically I can write the tests without
this, using Anonymous children instead, but since that's more of a legacy
pattern I figured this was justified.
Also I just grepped for "nest" in the configsets directory and not a single
other config has this defined, hopefully that's not a bad omen for test
coverage on named child docs 😨. (Edit: other directories have configs with it
defined. I don't know the context/distinction between the pile of configs in
`collection1` and `configsets`, which this test class is using.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
