gerlowskija opened a new pull request, #2802: URL: https://github.com/apache/solr/pull/2802
https://issues.apache.org/jira/browse/SOLR-17515 # Description Prior to this commit, Http2SolrClient only initialized its 'authenticationStore' instance var when creating a fresh Jetty HttpClient. This causes NPE's later on when client code (e.g. PreemptiveBasicAuthClientBuilderFactory) would attempt to access the object. # Solution This commit fixes this by making sure that 'authenticationStore' is initialized when using an existing Jetty client (typically by reusing the AuthenticationStore already used by the client). # Tests Strengthens an existing test, RecoveryZkTestWithAuth, by randomizing use of some sysprops helpful for reproducing. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
