epugh commented on PR #2820: URL: https://github.com/apache/solr/pull/2820#issuecomment-2450147305
> @janhoy in commit [2f3c0ef](https://github.com/apache/solr/commit/2f3c0ef959b6a1f921217ef30da5347ec17a5b5f) I removed the passing of the `-j` (Jetty options) into the RunExampleTool because it was an option that was ignored. You added the line in the bin/solr so wanted to flag this to you in case you think we need to someone add this capability to RunExampleTool! @janhoy never mind, turns out regardless of running Solr in foreground or not, we pass in the settings via `start_solr "$FG" "${ADDITIONAL_CMD_OPTS:-}" "${ADDITIONAL_JETTY_CONFIG:-}"`. So the removed line was never actually used! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
