dsmiley commented on code in PR #2828:
URL: https://github.com/apache/solr/pull/2828#discussion_r1826120759
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##########
@@ -173,8 +173,8 @@ public NamedList<Object> request(SolrRequest<?>
solrRequest, String collection)
"Timeout occurred while waiting response from server at: " +
pReq.url, e);
} catch (SolrException se) {
throw se;
- } catch (RuntimeException re) {
- throw new SolrServerException(re);
+ } catch (IOException | RuntimeException e) {
Review Comment:
Actually, maybe LBHttpSolrClient should be enhanced to catch the IOException
to behave properly here? Otherwise, it seems wrong just looking at this
SolrClient to throw/not-throw based on some wrapping/delegating client unless
we spell out these things in the documented semantics of this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
