psalagnac commented on PR #2737: URL: https://github.com/apache/solr/pull/2737#issuecomment-2454956000
> One thought, is there a way to enforce the use of waitForState() pattern via any of our code quality tools? Not sure how we can automate decision on whether usages of `Timeout` are legit or not. We should use `waitForState()` instead of busy waiting for changes in Zookeeper, so we leverage the registered watchers. There are other cases, mostly when doing Solr-to-Solr requests, where we should keep `Timeout`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
