malliaridis commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1830087669
##########
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##########
@@ -569,7 +564,7 @@ private void updateIncludeFileEnableAuth(
includeFileLines.add("REM The following lines added by solr.cmd for
enabling BasicAuth");
includeFileLines.add("set SOLR_AUTH_TYPE=kerberos");
includeFileLines.add(
- "set SOLR_AUTHENTICATION_OPTS=\"-Dsolr.httpclient.config=" +
basicAuthConfFile + "\"");
+ "set
SOLR_AUTHENTICATION_OPTS=\"-Dsolr.httpclient.config=basicAuthConfFile\"");
Review Comment:
What exactly is the effect of this change? Is the string `basicAuthConfFile`
here expected as value? We have two more references in AuthTool that mention
`SOLR_AUTHENTICATION_OPTS`. Do they maybe also need ot be updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
