alessandrobenedetti commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2460580259
I was able to find:
org.apache.solr.filestore.ClusterFileStore -> implements ClusterFileStoreApis
org.apache.solr.filestore.NodeFileStore -> implements NodeFileStoreApis
org.apache.solr.filestore.DistribFileStore -> implements FileStore
it's not clear how they differ and there's no documentation I could easily
find.
Given that I ended up finding : req.getCoreContainer().getFileStore() and it
returns a org.apache.solr.filestore.DistribFileStore, so by best bet is that
the file-store @dsmiley is referring is:
org.apache.solr.filestore.DistribFileStore
Now, that FileStore has a get method
'org.apache.solr.filestore.DistribFileStore#get' that surprisingly doesn't
return anything (return type is void) but has a convoluted way of consuming the
output rather than returning it.
Anyway, I'm progressing this route and I should be able to have additional
insights tomorrow.
My first feedback on this follows:
1) it took me a decent amount of time to implement the functionality taking
inspiration from the LTR module, it's taking way more time to do it via the
FileStore.
It's not easy to find information about it on the Reference guide, and it
was not intuitive to understand the right code to look at.
If that's the route we want new developers to follow for storing models and
similar managed resources in Solr, I suspect we need to make it way easier to
understand and interact with.
JavaDocs were pretty much missing and code examples or tests not easy to be
found.
N.B. these are just pragmatic observations to improve it, no offence to
whoever designed and implemented this (I have not even checked)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
