risdenk commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1838502296
##########
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java:
##########
@@ -92,8 +92,7 @@ public void init(final NamedList<?> args) {
String algorithmString = params.get(ALGORITHM_PARAM);
Algorithm classificationAlgorithm;
try {
- if (algorithmString == null
- || Algorithm.valueOf(algorithmString.toUpperCase(Locale.ROOT)) ==
null) {
Review Comment:
I agree that should be done first so we can make sure that all the rules are
put into
https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle#L68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
