[
https://issues.apache.org/jira/browse/SOLR-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910257#comment-17910257
]
David Smiley commented on SOLR-17612:
-------------------------------------
The fix would likely be that each shard would need to compute the integer
maxResultsByFilters, putting it in its response, and then the coordinator in
maxResultsForSuggest() can add them and then multiply by
maxResultsForSuggestParamValue.
> spellcheck.maxResultsForSuggest percentage is flawed when multiple shards
> -------------------------------------------------------------------------
>
> Key: SOLR-17612
> URL: https://issues.apache.org/jira/browse/SOLR-17612
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Affects Versions: 5.5
> Reporter: David Smiley
> Priority: Major
>
> The {{spellcheck.maxResultsForSuggest}} param can be a fraction. When it is a
> fraction, the code {{SpellcheckComponent.maxResultsForSuggest()}} will open
> the Searcher of the current core to evaluate a query against local data. The
> details of this don't matter but this code is executed on the coordinator
> core of the query in distributed search because it's called by
> {{{}org.apache.solr.handler.component.SpellCheckComponent#finishStage{}}}.
> This core could be empty (when using a coordinator node feature) or may
> simply not be represenatiative. The ramification is that the internal
> boolean isCorrectlySpelled would always be true (assuming no local data) and
> not get the spell correction it should have gotten with an accurate threshold.
> _Credit to my colleague_ [~pvcnt]{_}. We tend to think there's a design flaw
> in Solr distributed search that permits a coordinator to get a Searcher from
> a request that should be blocked, catching a bug like this early.{_}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
