gerlowskija commented on code in PR #722:
URL: https://github.com/apache/solr-operator/pull/722#discussion_r1905586024
##########
api/v1beta1/solrcloud_types.go:
##########
@@ -1160,6 +1160,9 @@ type SolrCloudStatus struct {
// BackupRepositoriesAvailable lists the backupRepositories specified
in the SolrCloud and whether they are available across all Pods.
// +optional
BackupRepositoriesAvailable map[string]bool
`json:"backupRepositoriesAvailable,omitempty"`
+
+ // ObservedGeneration represents the most recent generation observed
for this SolrCloud.
+ ObservedGeneration int64 `json:"observedGeneration"`
Review Comment:
[Q] Are there any edge-cases where there won't be an `observedGeneration`,
say, immediately after creating a SolrCloud but before the operator has created
any of the resources backing it?
Assuming that case exists, I guess the 'observedGeneration' would just be
'0' in that case, and that's probably fine unless it'd be better to make the
field an optional `*int64`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
