mlbiscoc commented on code in PR #3006:
URL: https://github.com/apache/solr/pull/3006#discussion_r1908950933
##########
solr/core/src/java/org/apache/solr/metrics/prometheus/core/SolrCoreMetric.java:
##########
@@ -29,7 +30,8 @@ public abstract class SolrCoreMetric extends SolrMetric {
Pattern.compile(
"(?<core>^core_(?<collection>.*)_(?<shard>shard[0-9]+)_(?<replica>replica_.[0-9]+)).(.*)$");
public static Pattern STANDALONE_CORE_PATTERN =
Pattern.compile("^core_(?<core>.*?)\\.(.*)$");
-
+ public static List<String> CLOUD_LABEL_KEYS = List.of("core", "collection",
"shard", "replica");
+ public static List<String> STANDALONE_LABEL_KEYS = List.of("core");
Review Comment:
I did a static List of the keys for each regex expression instead of the Map
and looped through these to add the labels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
