dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924087626
##########
solr/solrj/src/java/org/apache/solr/common/util/Utils.java:
##########
@@ -748,61 +745,6 @@ public static String applyUrlScheme(final String url,
final String urlScheme) {
return (at == -1) ? (urlScheme + "://" + url) : urlScheme +
url.substring(at);
}
- /**
- * Construct a V1 base url for the Solr node, given its name (e.g.,
'app-node-1:8983_solr') and a
- * URL scheme.
- *
- * @param nodeName name of the Solr node
- * @param urlScheme scheme for the base url ('http' or 'https')
- * @return url that looks like {@code https://app-node-1:8983/solr}
- * @throws IllegalArgumentException if the provided node name is malformed
- */
- public static String getBaseUrlForNodeName(final String nodeName, final
String urlScheme) {
Review Comment:
These methods are called in a bunch of places; we can't simply remove them
in 9x. They can stay and call the new location and be deprecated.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -248,15 +240,19 @@ > getCacheTimeout()) {
+ "succeeded in obtaining the cluster state from none of them."
+ "If you think your Solr cluster is up and is accessible,"
+ " you could try re-creating a new CloudSolrClient using
working"
- + " solrUrl(s) or zkHost(s).");
+ + " solrUrl(s).");
} else {
return this.liveNodes; // cached copy is fresh enough
}
}
+ private boolean updateLiveNodes(List<String> liveNodes) {
+ return updateLiveNodes(Set.copyOf(liveNodes));
+ }
+
private boolean updateLiveNodes(Set<String> liveNodes) {
Review Comment:
why does updateLiveNodes take a Set as an argument; can't it simply be a
Collection? The Set is forcing you to do a conversion and that which changes
the order, and the order may be deliberate. It's not worth overloading the
method for either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
