dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924605334
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ClusterStateProviderTest.java:
##########
@@ -204,8 +204,8 @@ public void
testClusterStateProviderDownedInitialLiveNodes() throws Exception {
var jettyNode1 = cluster.getJettySolrRunner(0);
var jettyNode2 = cluster.getJettySolrRunner(1);
- String nodeName1 =
getNodeNameFromSolrUrl(jettyNode1.getBaseUrl().toString());
- String nodeName2 =
getNodeNameFromSolrUrl(jettyNode2.getBaseUrl().toString());
+ String nodeName1 =
getNodeNameForBaseUrl(jettyNode1.getBaseUrl().toString());
Review Comment:
Was From -> For deliberate? IMO it was named fine.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -387,6 +398,19 @@ public String getPolicyNameByCollection(String coll) {
+ "ZkClientClusterStateProvider can be used for this."); // TODO
}
+ private List<URL> setConfiguredNodes(List<String> solrUrls) {
Review Comment:
this doesn't actually "set" anything; it's a utility function mapping input
to output converting to a URL. It could even be static. If you declare a
static method that only converts a URL with the try-catch, it'd be simple for
the caller (init) to invoke it with the streams mapping in a one-liner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
