[
https://issues.apache.org/jira/browse/SOLR-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17623.
---------------------------------
Fix Version/s: 9.9
Resolution: Fixed
Nice; thanks again Renato! If you are interested in more nearby work, you
might find the linked issue SOLR-17635 advances a goal that will very much use
this.
Or maybe work on NamedList.asShallowMap going away by altering its callers. As
I look at its callers, it will have varied solutions, so maybe harder to work
on. I once sought improvement to NamedList.asShallowMap but as I thought about
it, it ought to only be used when we know the NamedList is effectively a map
(no repeating keys) but in that case, ought to already be a SimpleOrderedMap
(some work needed to transition some impls) and thus SOM should implementing
Map; and there are we are today.
> SimpleOrderedMap should implement Map
> -------------------------------------
>
> Key: SOLR-17623
> URL: https://issues.apache.org/jira/browse/SOLR-17623
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Priority: Major
> Labels: newdev, pull-request-available
> Fix For: 9.9
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> SimpleOrderedMap is semantically a Map; it should implement Map.
> Why: This will help us transition away from NamedList (it's superclass) in a
> number of places, since many (most?) places that are defined to return a
> NamedList could actually be declared to be a SimpleOrderedMap and eventually
> simply Map.
> There's some risk that code somewhere gets this Map, a large one, and then
> assumes it has better than O(N) lookup, which it doesn't provide. Perhaps a
> Javadoc warning will do.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
