mcarroll1 commented on code in PR #744:
URL: https://github.com/apache/solr-operator/pull/744#discussion_r1939586626
##########
config/crd/bases/solr.apache.org_solrclouds.yaml:
##########
@@ -10205,29 +10205,37 @@ spec:
description: |-
Configure a user-provided security.json from a secret to
allow for advanced security config.
If not specified, the operator bootstraps a
security.json with basic auth enabled.
- This is a bootstrapping config only; once Solr is
initialized, the security config should be managed by the security API.
properties:
- key:
- description: The key of the secret to select from.
Must be
- a valid secret key.
- type: string
- name:
- default: ""
+ bootstrapSecurityJson:
+ description: SecretKeySelector selects a key of a
Secret.
+ properties:
+ key:
+ description: The key of the secret to select from.
Must
+ be a valid secret key.
+ type: string
+ name:
+ default: ""
+ description: |-
+ Name of the referent.
+ This field is effectively required, but due to
backwards compatibility is
+ allowed to be empty. Instances of this type with
an empty value here are
+ almost certainly wrong.
+ More info:
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
+ type: string
+ optional:
+ description: Specify whether the Secret or its key
must
+ be defined
+ type: boolean
+ required:
+ - key
+ type: object
+ x-kubernetes-map-type: atomic
+ probesRequireAuth:
Review Comment:
Resolved!
##########
api/v1beta1/solrcloud_types.go:
##########
@@ -1621,6 +1624,15 @@ const (
Basic AuthenticationType = "Basic"
)
+type BootstrapSecurityJson struct {
+ SecurityJsonSecret *corev1.SecretKeySelector
`json:"bootstrapSecurityJson,omitempty"`
+
+ // Flag to indicate if the operator should overwrite an existing
security.json if there are changes
+ // as compared to the underlying secret
+ // +optional
+ Overwrite bool `json:"probesRequireAuth,omitempty"`
Review Comment:
Resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
