malliaridis commented on code in PR #3153: URL: https://github.com/apache/solr/pull/3153#discussion_r1939602273
########## solr/bin/solr.cmd: ########## @@ -94,7 +94,10 @@ IF NOT DEFINED SOLR_SSL_RELOAD_ENABLED ( set "SOLR_SSL_RELOAD_ENABLED=true" ) -REM Enable java security manager by default (limiting filesystem access and other things) +REM Enable java security manager by default for Java 23 and before (limiting filesystem access and other things) +IF !JAVA_MAJOR_VERSION! GEQ "24" ( Review Comment: I've tested again the Windows script changes, seems like the condition is always true, regardless the java version. This should fix the issue: ```suggestion IF !JAVA_MAJOR_VERSION! GEQ 24 ( ``` Note that it matter whether you set `JAVA_HOME` or update the `PATH` variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
