dsmiley commented on code in PR #3182:
URL: https://github.com/apache/solr/pull/3182#discussion_r1954847559
##########
solr/core/src/java/org/apache/solr/handler/admin/api/ReplicationAPIBase.java:
##########
@@ -377,7 +383,9 @@ public void write(OutputStream out) throws IOException {
try {
initWrite();
- Directory dir = solrCore.withSearcher(searcher ->
searcher.getIndexReader().directory());
+ Directory dir =
+ filterDirectory(
+ solrCore.withSearcher(searcher ->
searcher.getIndexReader().directory()));
Review Comment:
This seems to be the point of this PR. Firstly, I'd rather see us get the
Directory from the SolrCore.getDirectoryFactory as it doesn't seem very
searcher-related. Secondly, I think the DirectoryFactory ought to be able to
return different different instances depending on the use-case/need. See
`DirectoryFactory.DirContext`. Imagine having a new `REPLICATE` option that's
only for moving bytes, for either backups or replication (both being similar)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
