[
https://issues.apache.org/jira/browse/SOLR-13212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927868#comment-17927868
]
Chris M. Hostetter commented on SOLR-13212:
-------------------------------------------
{quote}Should this ticket be marked resolved? ... I see a commit...
{quote}
1) The problem is not specific to HDFS, and the class in question still
exists...
{quote}While investigating suite level test failures in
{{RestartWhileUpdatingTest}} (and it's subclass
{{{}HdfsRestartWhileUpdatingTest{}}}) ...
{quote}
2) The commit(s) did not fix anything, it just disabled the test injection
randomization that was guaranteed to trigger the test failure.
3) AFAICT no one who understands this test has stepped up to answer the
fundamental questions as to whether or not this is a "real" bug in Solr, or
just a badly written test...
{quote}It's not clear to me if the root problem here is that the
CoreContainer/Jetty isn't handling the ungraceful close well enough, and
ensuring that the SolrCore (and stuff hanging off of it) is freed up for GC, or
if the test should be doing something to account for this possibility and
ammending/disabling the ObjectTracker?
{quote}
> when TestInjection.nonGracefullClose causes a TestShutdownFailError, test is
> garunteed tofail due to leaked objects (causes failures in
> (Hdfs)RestartWhileUpdatingTest)
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-13212
> URL: https://issues.apache.org/jira/browse/SOLR-13212
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-13212.patch
>
>
> While investigating suite level test failures in
> {{RestartWhileUpdatingTest}} (and it's subclass
> {{HdfsRestartWhileUpdatingTest}}) due to leaked objects i realized that this
> happens anytime {{TestInjection.injectNonGracefullClose}} causes a
> {{TestShutdownFailError}} to be thrown.
> The test will still be able to restart the node, and the test (method) will
> succeed, but the suite will fail due to the leaked objects.
> NOTE: These are currently the only tests using
> {{TestInjection.nonGracefullClose}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
