malliaridis commented on code in PR #3195:
URL: https://github.com/apache/solr/pull/3195#discussion_r1961745491
##########
solr/ui/build.gradle.kts:
##########
@@ -55,14 +55,9 @@ kotlin {
// Note that webpack.config.d/ contains additional
configuration
}
testTask {
- useKarma {
- useChromeHeadless()
- useConfigDirectory(
- project.projectDir
- .resolve("karma.config.d")
- .resolve("wasm")
- )
- }
+ // Explicitly disable the wasmJs browser tests, as we do not
have the suitable
+ // environments right now (running only tests for JVM)
+ enabled = false
Review Comment:
Yes, I agree. I was considering adding a flag, but then I realized that just
a flag won't be sufficient. By using Karma, we also have to make a browser
selection, which, will affect the lock state if we enable a specific browser
(as it adds additional NPM dependencies) and it requires lock state update via
`gradlew kotlinUpgradeYarnLock`.
I would use Mocha instead, but doesn't seem like it works out of the box.
Simply disabling testing for wasmJs fixes one critical issue for our
automations, but doesn't solve the actual problem.
I have created
[SOLR-17676](https://issues.apache.org/jira/browse/SOLR-17676) for keeping
track of this topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
