gerlowskija commented on code in PR #3206:
URL: https://github.com/apache/solr/pull/3206#discussion_r1967557670
##########
solr/core/src/java/org/apache/solr/search/join/HashRangeQuery.java:
##########
@@ -91,6 +96,9 @@ private int[] getCache(LeafReaderContext context) throws
IOException {
if (cacheHelper == null) {
return null;
}
+ if (!(searcher instanceof SolrIndexSearcher)) { // e.g. delete-by-query
Review Comment:
[Q] How important is the caching, do you know? Is it enough of a change
that it's worth documenting the degraded performance when run as a DBQ?
(Not implying it is, just asking from a due-diligence perspective.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
