David Smiley created SOLR-17682:
-----------------------------------
Summary: Refactor QueryResponseWriter hierarchy to put binary at
the base and add TextQueryResponseWriter sub
Key: SOLR-17682
URL: https://issues.apache.org/jira/browse/SOLR-17682
Project: Solr
Issue Type: Improvement
Reporter: David Smiley
The QueryResponseWriter hierarchy should be inverted. Instead of Writer/Text
being at the base with a subclass (BinaryResponseWriter) doing
OutputStream/Binary, it should be inverted. QueryResponseWriter should have
write(OutputStream,...) and there should be a subclass/interface
TextResponseWriter for the textual formats. Once this is done, there are some
awkward methods that do casting (a code smell) that will instead be simplified.
There will be no use for QueryResponseWriterUtil. This is all best shown in a
PR to see why it's better.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
