dsmiley commented on code in PR #3209:
URL: https://github.com/apache/solr/pull/3209#discussion_r1970929169
##########
solr/core/src/java/org/apache/solr/response/QueryResponseWriter.java:
##########
@@ -39,23 +41,26 @@
* <p>A single instance of any registered QueryResponseWriter is created via
the default constructor
* and is reused for all relevant queries.
*/
+@ThreadSafe
public interface QueryResponseWriter extends NamedListInitializedPlugin {
public static String CONTENT_TYPE_XML_UTF8 = "application/xml;
charset=UTF-8";
public static String CONTENT_TYPE_TEXT_UTF8 = "text/plain; charset=UTF-8";
public static String CONTENT_TYPE_TEXT_ASCII = "text/plain;
charset=US-ASCII";
/**
- * Write a SolrQueryResponse, this method must be thread save.
- *
- * <p>Information about the request (in particular: formatting options) may
be obtained from
- * <code>req</code> but the dominant source of information should be
<code>rsp</code>.
- *
- * <p>There are no mandatory actions that write must perform. An empty write
implementation would
- * fulfill all interface obligations.
+ * Writes the response to the {@link OutputStream}. {@code contentType} is
from {@link
+ * #getContentType(SolrQueryRequest, SolrQueryResponse)}, and it's often
ignored.
*/
- public void write(Writer writer, SolrQueryRequest request, SolrQueryResponse
response)
+ void write(
+ OutputStream out, SolrQueryRequest request, SolrQueryResponse response,
String contentType)
Review Comment:
It's a debatable change... it'd be less disruptive to leave it as it was and
then only the text formats will re-acquire it which is fairly trivial parsing
to do a second time. Shrug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
