gerlowskija commented on code in PR #3190:
URL: https://github.com/apache/solr/pull/3190#discussion_r1989607793
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -411,21 +411,25 @@ private static void printHelp() {
print(
" zk ls, zk cp, zk rm , zk mv, zk
mkroot, zk upconfig, zk downconfig,");
print(
- " snapshot-create, snapshot-list,
snapshot-delete, snapshot-export, snapshot-prepare-export");
+ " snapshot-create, snapshot-list,
snapshot-delete, snapshot-export");
print("");
- print(" Standalone server example (start Solr running in the background
on port 8984):");
+ print(" Start Solr on default port 8983:");
Review Comment:
I think I’m fine with --user-managed being second. Between the help-text
ordering and the “user-managed” name itself (which IMO correctly implies more
responsibility+work for the user) - we’re giving new users a pretty substantial
nudge towards SolrCloud. Personally, I think that’s great.
But I'm a little uncomfortable with the wording that's here in the “first
spot”. It doesn't really clarify the mode one way or another. And that feels
a little dangerous in a release that also happens to switch the "default" mode!
90% of users coming from 9.x standalone will read that and (incorrectly) miss
that the default mode has changed.
Please consider adding a tweak here so that the "First spot" does
_something_ to indicate the mode ("SolrCloud", mention ZooKeeper, etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
