uschindler commented on PR #3261:
URL: https://github.com/apache/solr/pull/3261#issuecomment-2722212518
> > Could we also disable it by default in the OS/Arch values we know are
unsupported, as well as the ALT JDK option?
>
> This can be done by checking the values set in
`System.getProperty("os.name")` and `System.getenv("RUNTIME_JAVA_HOME")` (or is
it also just a property?) I believe? The main challenge is to disable the
module during the initialization phase, which has not loaded any gradle script
like `alternative-jdk-support.gradle`.
It is not only the env var. You can also set an alternative JDK with a
sysprop or project property. I am not sure if you can check all this duing
early setup.
Basically I don't like this at all. Can we not just move away from Kotlin? I
am not happy that we have a mixed build. Either all in Kotlin or nothing.
> Which operating systems are not supported besides s390x? If we get a more
complex logic, I would extract it to a separate script and apply it like we do
with `gradle/lucene-dev/lucene-dev-repo-composite.gradle`.
>
> It also seems that it works well and does not complain about invalid lock
state, which I was expecting at first when disabling the module.
Uwe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
