[
https://issues.apache.org/jira/browse/SOLR-17682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935377#comment-17935377
]
ASF subversion and git services commented on SOLR-17682:
--------------------------------------------------------
Commit b4ee7fc8333b5bba48b85e680f6dae6e45cd651b in solr's branch
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=b4ee7fc8333 ]
SOLR-17682: QueryResponseWriter hierarchy refactor (#3209)
Base abstraction is now byte oriented, thus BinaryQueryResponseWriter is gone.
Added TextQueryResponseWriter for the text ones. Stopped using
RawResponseWriter when not needed.
Added writeToString
QueryResponseWriterUtil is removed
Declare throw IOException from write(...)
> Refactor QueryResponseWriter hierarchy to put binary at the base and add
> TextQueryResponseWriter sub
> ----------------------------------------------------------------------------------------------------
>
> Key: SOLR-17682
> URL: https://issues.apache.org/jira/browse/SOLR-17682
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The QueryResponseWriter hierarchy should be inverted. Instead of Writer/Text
> being at the base with a subclass (BinaryResponseWriter) doing
> OutputStream/Binary, it should be inverted. QueryResponseWriter should have
> write(OutputStream,...) and there should be a subclass/interface
> TextResponseWriter for the textual formats. Once this is done, there are
> some awkward methods that do casting (a code smell) that will instead be
> simplified. There will be no use for QueryResponseWriterUtil. This is all
> best shown in a PR to see why it's better.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
