[
https://issues.apache.org/jira/browse/SOLR-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935379#comment-17935379
]
David Smiley commented on SOLR-17518:
-------------------------------------
As I now look in branch_9x, this was a non-backwards-compatible change. A
SolrJ user wanting to send as XML would create a new RequestWriter but now it's
abstract; that won't work. Also the CHANGES.txt entry isn't indicative of the
magnitude of the change:
{quote} SOLR-17518: Deprecate UpdateRequest.getXml() and replace it with
XMLRequestWriter. (Pierre Salagnac){quote}
Back-compat is a pain; I question if attempting to bother to try to uphold it
is worth it for a refactoring like this.
> Refactor out a XmlRequestWriter so that RequestWriter is abstract
> -----------------------------------------------------------------
>
> Key: SOLR-17518
> URL: https://issues.apache.org/jira/browse/SOLR-17518
> Project: Solr
> Issue Type: Task
> Components: SolrJ
> Reporter: David Smiley
> Assignee: Pierre Salagnac
> Priority: Minor
> Labels: newdev, pull-request-available
> Fix For: main (10.0), 9.9
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> RequestWriter writes XML; some subclasses write other things. This is
> terrible API design; the XML choice should be a subclass, RequestWriter
> should be abstract (or an interface).
> While we're at this, the XML generation is kind of split into multiple
> places; it should be consolidated: UpdateRequest & ClientUtils have XML
> generation methods. Those methods should move to the new XmlRequestWriter.
> BinaryRequestWriter should probably be final and/or ensure the CBOR one does
> not subclass it, which is weird since CBOR != "javabin".
> Be sure to note this refactoring in the update notes since SolrJ users will
> be impacted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
