gerlowskija commented on PR #769:
URL: https://github.com/apache/solr-operator/pull/769#issuecomment-2725240241
I think our existing testing (see
`tests/e2e/solrcloud_security_json_test.go`) is sufficient here. It never
caught the #759 error, because it's not actually an error ("just" some noise in
the logs)!
`grep -q` does print a message to stderr, but it doesn't impact the return
status of the `grep` call, which returns zero/non-zero based on whether it
finds a match in `/tmp/current_security.json`. `grep` doesn't care that you
also asked it to search other files (i.e. `]`) that don't exist. So despite
the syntax error, the overall conditional still operated as we wanted it to.
We could add an additional test case to `solrcloud_security_json_test.go`,
to cover the case of a security.json file whose contents are `{}`, but IMO that
edgecase is rare enough that it's not worth bloating the runtime of our e2e
tests.
If anyone disagrees though, lmk and I'll add it in. Otherwise, I'll
probably target early next week to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
