gerlowskija commented on PR #3262: URL: https://github.com/apache/solr/pull/3262#issuecomment-2729650633
> a test would be nice Tests added in `V2ApiIntegrationTest` > It's a mystery to me how this PR accomplishes that goal. Really it doesn't. Jersey will parse the "Accept" header out of the box, and choose a "MessageBodyWriter" (akin to our ResponseWriter") based on that. But I'd hidden this support in the past by creating a "response filter" (`MediaTypeOverridingFilter`) to key off of only the 'wt' parameter. So what this PR is really doing is tweaking `MediaTypeOverridingFilter` to be slightly less aggressive. It still obeys "wt" when provided, and makes sure that JSON is the default otherwise. But now it only leans on that "JSON" default when there's no "wt" AND there's no "Accept" header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
