dsmiley commented on code in PR #3270:
URL: https://github.com/apache/solr/pull/3270#discussion_r2006260069
##########
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##########
@@ -240,9 +241,9 @@ public RequestWriter.ContentWriter getContentWriter(String
expectedType) {
/**
* Create a new SolrResponse to hold the response from the server
*
- * @param client the {@link SolrClient} the request will be sent to
+ * @param namedList the {@link SolrClient} the request will be sent to
*/
- protected abstract T createResponse(SolrClient client);
+ protected abstract T createResponse(NamedList<Object> namedList);
Review Comment:
Right; no impl uses it yet; the V2 API certainly will; maybe I'll show that
this weekend. I could change the V1 APIs to use it; it'd increase the scope of
this PR a good deal but for the better. On the other hand, there's a case for
leaving them be; we're moving on to V2 after all. If you like, I could do this
to one response to show you what that looks like. Maybe I'll just do that now;
it's not hard. Other than that; I think what I already wrote (which is a lot)
establishes the context. If it's still not clear, you might find checking out
the PR to see it naturally and not as a diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
