dsmiley commented on code in PR #3282:
URL: https://github.com/apache/solr/pull/3282#discussion_r2008841563
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java:
##########
@@ -96,7 +97,7 @@ public static void postFile(SolrClient client, ByteBuffer
buffer, String name, S
uploadReq.setSig(List.of(sig));
}
- final var uploadRsp = uploadReq.process(client).getParsed();
+ final UploadToFileStoreResponse uploadRsp = uploadReq.process(client);
Review Comment:
IMO we've been using `var` too much.
##########
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##########
@@ -322,7 +322,7 @@ public static boolean safeCheckCoreExists(String solrUrl,
String coreName, Strin
Thread.sleep(clamPeriodForStatusPollMs);
}
final var coreStatusReq = new CoresApi.GetCoreStatus(coreName);
- final var coreStatusRsp =
coreStatusReq.process(solrClient).getParsed();
Review Comment:
I admit the result of this work as seen in consuming/calling code right here
is _merely_ removing `getParsed()` since there is now no intermediate class
holding the parsed value. But anyone browsing the generated code / class
hierarchy will now see something simpler.
##########
solr/solrj/src/resources/java-template/api.mustache:
##########
@@ -91,17 +90,13 @@ public class {{classname}} {
{{#operation}}
{{^vendorExtensions.x-omitFromCodegen}}
{{#vendorExtensions.x-rawOutput}}
- public static class {{operationIdCamelCase}}Response extends
InputStreamResponse {}
+ public static class {{operationIdCamelCase}} extends SolrRequest
+ <InputStreamResponse> {
{{/vendorExtensions.x-rawOutput}}
{{^vendorExtensions.x-rawOutput}}
- public static class {{operationIdCamelCase}}Response extends
JacksonParsingResponse<{{modelPackage}}.{{returnType}}> {
Review Comment:
gone!
##########
solr/solrj/src/test/org/apache/solr/client/solrj/ApiMustacheTemplateTests.java:
##########
Review Comment:
seems obsolete now
##########
solr/solrj/src/resources/java-template/api.mustache:
##########
@@ -91,17 +90,13 @@ public class {{classname}} {
{{#operation}}
{{^vendorExtensions.x-omitFromCodegen}}
{{#vendorExtensions.x-rawOutput}}
- public static class {{operationIdCamelCase}}Response extends
InputStreamResponse {}
Review Comment:
gone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
