[
https://issues.apache.org/jira/browse/SOLR-17723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943332#comment-17943332
]
ASF subversion and git services commented on SOLR-17723:
--------------------------------------------------------
Commit 22f8fd3d4f61c208427271aadcc6c62b16e0f2a1 in solr's branch
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=22f8fd3d4f6 ]
SOLR-17723: FeaturesSelectionStream: refactorings (#3296)
Use Java Streams and with tuple iteration on-demand
Use Java Map.merge
Use NamedList.forEach instead of indexed iteration
> NamedList: update most callers of indexed access with alternatives
> ------------------------------------------------------------------
>
> Key: SOLR-17723
> URL: https://issues.apache.org/jira/browse/SOLR-17723
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Fix For: main (10.0)
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> A number of methods on NamedList are index based. – indexOf(key),
> getName(idx), getVal(idx), and more. For a number of reasons, _most_ (not
> all) callers should use alternatives, namely forEach or iterator(). Why:
> will lessen the scope of impact of transitioning many NamedList usages to
> Map. Map's methods are more familiar, and both forEach and iterator() are
> slightly easier to read than indexed access.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
