psalagnac commented on code in PR #3315:
URL: https://github.com/apache/solr/pull/3315#discussion_r2033055514
##########
solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java:
##########
@@ -183,7 +180,7 @@ protected void runCloudTool(CloudSolrClient
cloudSolrClient, CommandLine cli) th
}
// if we get here, we can trust the state
- replicaStatus = replicaCoreProps.getState();
+ replicaStatus = String.valueOf(r.getState());
Review Comment:
The different is `.toString()` would raise a NPE in case `r.getState()`
returns `null`. This is supposed to never happen, but since old code was
accepting null values; I made sure new code too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
