[
https://issues.apache.org/jira/browse/SOLR-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944547#comment-17944547
]
ASF subversion and git services commented on SOLR-17069:
--------------------------------------------------------
Commit 9ec8b72b1af7a170eb6fa69fa6a0774c466287a1 in solr's branch
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=9ec8b72b1af ]
SOLR-17069: HttpServletRequest; use eagerly to avoid errors (#3324)
HttpServletRequest should be used only by the thread dispatched receiving it,
or else it _might_ produce errors (particularly in Jetty 12). Thus aspects of
the request that are needed should be eagerly consumed instead of deferred, to
avoid risks.
* Cache Span in HttpSolrCall to avoid NPE from Jetty 12 async request loss
* javadocs: warning for HttpSolrCall.getReq
* Cache the security UserPrincipal in SolrRequestInfo, and not the request
* CancellableQueryTracker: don't use HttpServletRequest
* HttpSolrCall: eager parse the user agent
* SolrRequestParsers: eagerly get the principal from the request
---------
Co-authored-by: Sanjay Dutt <[email protected]>
> Upgrade Jetty to 12.x
> ---------------------
>
> Key: SOLR-17069
> URL: https://issues.apache.org/jira/browse/SOLR-17069
> Project: Solr
> Issue Type: Improvement
> Components: Server
> Reporter: Kevin Risden
> Priority: Blocker
> Labels: pull-request-available
> Fix For: main (10.0)
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> On SOLR-16441 PR it was mentioned that Jetty 12.x supports multiple servlet
> versions and we could stick with javax.servlet instead of all the changes
> required to go to Jetty 11.x in SOLR-16441 PR.
> Jetty 12 requires JDK 17
> References:
> * https://webtide.com/introducing-jetty-12/
> *
> https://eclipse.dev/jetty/documentation/jetty-12/programming-guide/index.html#pg-migration-11-to-12
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
