epugh commented on PR #3278: URL: https://github.com/apache/solr/pull/3278#issuecomment-2810099575
@1995chen looks like you have some precommit errors to fix? Also, for this change, I don't see a unit test, do we have that already covered? I also would like some updates to the Reference Guide to cover these changes! We need to communicate how to use this new feature so it get's adopted and isn't a hidden thing! What is prompting the need to make these configurable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
