[ 
https://issues.apache.org/jira/browse/SOLR-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945444#comment-17945444
 ] 

ASF subversion and git services commented on SOLR-17043:
--------------------------------------------------------

Commit e08d7f0f0e66cdde389eb843db341f0eb5d833bb in solr's branch 
refs/heads/main from Jude Muriithi
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=e08d7f0f0e6 ]

SOLR-17043: Remove SolrClient path pattern matching (#3238)

Prior to this commit, the LB and Cloud clients looked at the URL path to make
some decisions around request routing, etc.  This logic was brittle and not 
really scalable to the more varied paths in Solr's v2 APIs.  This commit
replaces that logic to instead use a "request type" enum already that
SolrRequest objects make available.

---------

Co-authored-by: jmuriithi3 <jmuriit...@bloomberg.net>
Co-authored-by: Jason Gerlowski <gerlowsk...@apache.org>

> Remove SolrClient path pattern matching
> ---------------------------------------
>
>                 Key: SOLR-17043
>                 URL: https://issues.apache.org/jira/browse/SOLR-17043
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ, v2 API
>            Reporter: Jason Gerlowski
>            Priority: Minor
>              Labels: V2, pull-request-available
>          Time Spent: 8h
>  Remaining Estimate: 0h
>
> Currently, some SolrClient implementations (especially our "load-balancing" 
> and "cloud" clients) do pattern-matching on the path to guess the "type" 
> (admin, update, etc. ) of each request.  This seems unnecessary though, as 
> SolrRequest already has a "getRequestType" method exposing this.  We should 
> use this method where possible instead of the ad-hoc pattern matching we 
> currently do, which is brittle and doesn't map well to the varied paths used 
> by our v2 APIs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to