kotman12 commented on PR #3330: URL: https://github.com/apache/solr/pull/3330#issuecomment-2836117507
@psalagnac understood. @mlbiscoc had an idea of potentially using mockito spy for capturing the delete event although that has the drawback of all the pains of bytecode manipulation. The benefit is that Solr already uses this in a few spots. The other thought I had was using [log-captor](https://github.com/Hakky54/log-captor) which is a cool little apache-licensed lib that can have other uses but maybe a bit heavyweight to bring in for one test. We now log when this optimization _doesn't_ occur so capturing the logs and validating this line never gets printed might be an ok approach. Otherwise we are fine with no test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
