stillalex commented on code in PR #2687:
URL: https://github.com/apache/solr/pull/2687#discussion_r2066477252
##########
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##########
@@ -49,14 +48,13 @@ public OtelTracerConfigurator() {
}
@Override
- public Tracer getTracer() {
- return TraceUtils.getGlobalTracer();
+ public void init(NamedList<?> args) {
+ prepareConfiguration(args);
}
@Override
- public void init(NamedList<?> args) {
- prepareConfiguration(args);
- AutoConfiguredOpenTelemetrySdk.initialize();
+ public OpenTelemetry createOtel() {
+ return
AutoConfiguredOpenTelemetrySdk.builder().build().getOpenTelemetrySdk();
Review Comment:
this diff would have been easier to read if the 2 methods were not swapped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
