dsmiley commented on code in PR #2479:
URL: https://github.com/apache/solr/pull/2479#discussion_r2095533510
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##########
@@ -55,6 +50,8 @@ public class SolrClientCache implements Closeable {
private static final int minSocketTimeout =
Math.max(Integer.getInteger(HttpClientUtil.PROP_SO_TIMEOUT,
MIN_TIMEOUT), MIN_TIMEOUT);
+ private String basicAuthCredentials = null; // Only support with the
http2SolrClient
Review Comment:
@epugh I don't agree with this because it's basically a one-off setting
when there are many other potential settings. I don't think basic auth is so
special or so extremely widely used that it deserves its very own setter. It
sets an unfortunate precedent from someone interesting in setting something
else. The SolrClientCache _already_ provides a constructor that accepts an
existing HTTP client , and that which can be initialized with basic auth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
