[
https://issues.apache.org/jira/browse/SOLR-17758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952628#comment-17952628
]
ASF subversion and git services commented on SOLR-17758:
--------------------------------------------------------
Commit 733c41a6adae2786c367a1ecd05dcba2d09eab66 in solr's branch
refs/heads/main from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=733c41a6ada ]
SOLR-17758: Fix limiting-URP "warnOnly" mode (#3348)
Due to a bug in the initial implementation, the "warnOnly" mode of the
NumFieldLimiting "URP" never worked as designed. The "warn" codepath
failed to call `processAdd` for the next URP in the chain. This makes
the "warn only" behavior indistinguishable from the "hard limit"
behavior from a user perspective.
This commit fixes this bug. It also adds integration testing for
several "warn only" mode related scenarios, to prevent against future
regressions.
> NumFieldLimiting URP "warnOnly" mode broken
> -------------------------------------------
>
> Key: SOLR-17758
> URL: https://issues.apache.org/jira/browse/SOLR-17758
> Project: Solr
> Issue Type: Bug
> Components: UpdateRequestProcessors
> Affects Versions: 9.8.1
> Reporter: Jason Gerlowski
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> NumFieldLimitingUpdateProcessorFactory (introduced in SOLR-17192) aims to
> offer a "warnOnly" mode that logs a warning when the maximum number of fields
> is exceeded.
> But the "warnOnly" code path doesn't trigger any subsequent processors in the
> chain. So in effect, both modes will prevent new documents from being added
> once the limit has been exceeded.
> We should rework this logic so that the warnOnly=true codepath allows
> documents to be indexed as expected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
