[
https://issues.apache.org/jira/browse/SOLR-17765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952918#comment-17952918
]
Chris M. Hostetter commented on SOLR-17765:
-------------------------------------------
I didn't add any new logging, i just added SolrException to the existing logic
to catch+log+ignore logic to swallow the exception...
{noformat}
@@ -2986,7 +2986,7 @@ public class ZkController implements Closeable {
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
log.debug("Publish node as down was interrupted.");
- } catch (KeeperException e) {
+ } catch (KeeperException | SolrException e) {
log.warn("Could not publish node as down: ", e);
}
}
{noformat}
> Nodes should publish themselves as DOWN ASAP during shutdown
> ------------------------------------------------------------
>
> Key: SOLR-17765
> URL: https://issues.apache.org/jira/browse/SOLR-17765
> Project: Solr
> Issue Type: Bug
> Reporter: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-17765.patch
>
>
> While working on SOLR-17744 i noticed this comment in
> {{CoreContainerProvider.close()}} (that seems to date back to SOLR-15590) ...
> {noformat}
> // Mark Miller suggested that we should be publishing that we are down before
> anything else
> // which makes good sense, but the following causes test failures, so that
> improvement can be
> // the subject of another PR/issue. Also, jetty might already be refusing
> requests by this point
> // so that's a potential issue too. Digging slightly I see that there's a
> whole mess of code
> // looking up collections and calculating state changes associated with this
> call, which smells
> // a lot like we're duplicating node state in collection stuff, but it will
> take a lot of code
> // reading to figure out if that's really what it is, why we did it and if
> there's room for
> // improvement.
> // if (cc != null) {
> // ZkController zkController = cc.getZkController();
> // if (zkController != null) {
> // zkController.publishNodeAsDown(zkController.getNodeName());
> // }
> // }
> {noformat}
> ...I'm creating this Jira because I see no other existing Jira addressing
> this idea.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
