mlbiscoc opened a new pull request, #3415:
URL: https://github.com/apache/solr/pull/3415
I feel that the cardinality of `solr_metrics_core_requests_total` was
already high enough with the number of handlers + cores as labels and we are
bloating it with 3 different types of errors `client/server/timeouts`. This
makes things confusing and I think its justified errors has its own metric name
called `solr_metrics_core_requests_errors_total`.
Makes it very easy as well to create its own error aggregation by just
querying `solr_metrics_core_requests_errors_total{}` and you get all errors
without needs to specify the `type=errors` label.
```
solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="false",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",source="client"}
0.0
solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="false",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",source="server"}
0.0
solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="true",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",source="client"}
0.0
solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="true",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",source="server"}
0.0
solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="false",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",type="timeouts"}
0.0
solr_metrics_core_requests_errors_total{category="QUERY",collection="demo",core="demo_shard1_replica_n1",handler="/select",internal="true",otel_scope_name="org.apache.solr",replica="replica_n1",shard="shard1",type="timeouts"}
0.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
