HoustonPutman commented on code in PR #3398:
URL: https://github.com/apache/solr/pull/3398#discussion_r2188920181
##########
solr/core/src/java/org/apache/solr/update/PeerSync.java:
##########
@@ -246,7 +246,6 @@ public PeerSyncResult sync() {
if (log.isInfoEnabled()) {
log.info("{} DONE. sync failed", msg());
}
- shardHandler.cancelAll();
Review Comment:
Basically, the shardHandler will already cancel requests on a failure if
that is set, so this is no longer needed. I don't have to remove it, since it's
already cancelled. I'll reconsider this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
