[
https://issues.apache.org/jira/browse/SOLR-17777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18002677#comment-18002677
]
ASF subversion and git services commented on SOLR-17777:
--------------------------------------------------------
Commit 28a2ee239a32a58dad36aa14fa5f6a7187740131 in solr's branch
refs/heads/main from Pierre Salagnac
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=28a2ee239a3 ]
SOLR-17777: Fix leaked metric registry after core unload (#3382)
This fixes a minor memory leak when deleting a core. I don't think it can have
a significant impact on heap, but the fix is trivial and not risky.
> After core deletion, we keep an empty metric registry for this core
> -------------------------------------------------------------------
>
> Key: SOLR-17777
> URL: https://issues.apache.org/jira/browse/SOLR-17777
> Project: Solr
> Issue Type: Bug
> Components: metrics
> Affects Versions: 9.8
> Reporter: Pierre Salagnac
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I accidentally spotted a memory leak in metric registries. When a core is
> unloaded/deleted, we keep an empty metric registry for this core.
> This might have some very minor memory impacts if there is a very large
> number of collection creations and deletions, or core splits and moves during
> the server lifespan.
>
> This happens in {{SolrMetricManager.unregisterGauges()}} which is invoked
> after the registry was already dropped. As a side effect, this method
> recreates an empty registry.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
