bruno-roustant commented on code in PR #120:
URL: https://github.com/apache/solr-sandbox/pull/120#discussion_r2247326242
##########
encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java:
##########
@@ -258,196 +258,71 @@ public Name getPermissionName(AuthorizationContext
request) {
@Override
public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp)
throws Exception {
- long startTimeNs = getTimeSource().getTimeNs();
+ String keyId = getRequestKeyId(req, rsp);
+ checkEncryptionDirectoryFactory(req);
+ if (req.getParams().getBool(DISTRIB, false)) {
+ distributeRequest(req, rsp, keyId);
+ } else {
+ handleRequestLocally(req, rsp, keyId);
Review Comment:
The names sound good to me, and I have difficulty finding better names.
Maybe rename handleRequestLocally -> handleRequest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
