cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r2263724040
##########
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:
##########
@@ -112,14 +113,20 @@ public static LeafReader wrap(IndexReader reader) throws
IOException {
LeafMetaData leafMetaData =
reader.leaves().get(0).reader().getMetaData();
metaData =
new LeafMetaData(
- leafMetaData.getCreatedVersionMajor(),
+ leafMetaData.createdVersionMajor(),
minVersion,
- leafMetaData.getSort(),
+ leafMetaData.sort(),
leafMetaData.hasBlocks());
}
fieldInfos = FieldInfos.getMergedFieldInfos(in);
}
+ @Override
+ public DocValuesSkipper getDocValuesSkipper(String field) throws IOException
{
Review Comment:
I like the idea of a JIRA and it could be referenced in the code; _"TODO
implement skipping"_ on its own can appear concerning i.e. intentional vs.
accidental omission.
https://github.com/apache/lucene/blob/releases/lucene/10.2.1/lucene/core/src/java/org/apache/lucene/index/LeafReader.java#L205-L210
reassures that `null` means _"a skip index was not indexed"_ here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
