dsmiley commented on code in PR #3470: URL: https://github.com/apache/solr/pull/3470#discussion_r2279096050
########## solr/docker/templates/Dockerfile.body.template: ########## @@ -66,8 +66,7 @@ RUN set -ex; \ chmod 0664 /etc/default/solr.in.sh; \ mkdir -p -m0770 /var/solr; \ chown -R "$SOLR_USER:0" /var/solr; \ - test ! -e /opt/solr/modules || ln -s /opt/solr/modules /opt/solr/contrib; \ - test ! -e /opt/solr/prometheus-exporter || ln -s /opt/solr/prometheus-exporter /opt/solr/modules/prometheus-exporter; + test ! -e /opt/solr/modules || ln -s /opt/solr/modules /opt/solr/contrib; Review Comment: @HoustonPutman I recall you wanted this "contrib" symlink to ease 8.x -> 9.x. IMO in 10 we should remove it. Out with the old, in with the new. Belongs its own trivial PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
